lkml.org 
[lkml]   [2021]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] media: atomisp: fix `-Werror=return-type`
    From
    On 10/3/21 02:17, Ammar Faizi wrote:
    > Bedirhan reported build error:
    > ```
    > drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c: In function ‘input_system_configure_channel_sensor’:
    > drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c:1649:1: error: control reaches end of non-void function [-Werror=return-type]
    > 1649 | }
    > | ^
    > cc1: some warnings being treated as errors
    > make[4]: *** [scripts/Makefile.build:277: drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.o] Error 1
    > make[3]: *** [scripts/Makefile.build:540: drivers/staging/media/atomisp] Error 2
    > make[2]: *** [scripts/Makefile.build:540: drivers/staging/media] Error 2
    > make[1]: *** [scripts/Makefile.build:540: drivers/staging] Error 2
    > make: *** [Makefile:1868: drivers] Error 2
    > ```
    >
    > Commit 264f590899146baa19e0ab5689e55fadbc292333 ("media: atomisp:
    > remove useless returns") incorrectly removed a required return results
    > in the above build error. Reinstate it.
    >
    > Cc: Pavel Skripkin <paskripkin@gmail.com>
    > Cc: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
    > Cc: Sakari Ailus <sakari.ailus@linux.intel.com>
    > Cc: linux-media@vger.kernel.org
    > Cc: linux-staging@lists.linux.dev
    > Cc: linux-kernel@vger.kernel.org
    > Reported-by: Bedirhan KURT <windowz414@gnuweeb.org>
    > Fixes: 264f590899146baa19e0ab5689e55fadbc292333 ("media: atomisp: remove useless returns")
    > Signed-off-by: Ammar Faizi <ammar.faizi@students.amikom.ac.id>
    > ---
    > .../media/atomisp/pci/hive_isp_css_common/host/input_system.c | 1 +
    > 1 file changed, 1 insertion(+)
    >
    > diff --git a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c
    > index 8e085dda0c18..1bd917e81743 100644
    > --- a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c
    > +++ b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c
    > @@ -1646,6 +1646,7 @@ static input_system_err_t input_system_configure_channel_sensor(
    > default:
    > return INPUT_SYSTEM_ERR_PARAMETER_NOT_SUPPORTED;
    > }
    > + return INPUT_SYSTEM_ERR_NO_ERROR;
    > }
    >
    > // Test flags and set structure.
    >

    Hi, Ammar!


    Thank you for fixing this, but it's already fixed in linux-next tree.
    See commit 05344a1d2ea7 ("media: atomisp: restore missing 'return'
    statement").

    Again, I am sorry for introducing this bug :(




    With regards,
    Pavel Skripkin

    \
     
     \ /
      Last update: 2021-10-03 18:19    [W:5.716 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site