lkml.org 
[lkml]   [2021]   [Oct]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v4 00/10] fscache: Replace and remove old I/O API
    On Fri, Oct 29, 2021 at 10:55 AM David Howells <dhowells@redhat.com> wrote:
    >
    > This means bisection is of limited value and why I'm looking at a 'flag day'.

    So I'm kind of resigned to that by now, I just wanted to again clarify
    that the rest of my comments are about "if we have to deal with a flag
    dat anyway, then make it as simple and straightforward as possible,
    rather than adding extra steps that are only noise".

    > [ Snip explanation of netfslib ]
    > This particular patchset is intended to enable removal of the old I/O routines
    > by changing nfs and cifs to use a "fallback" method to use the new kiocb-using
    > API and thus allow me to get on with the rest of it.

    Ok, at least that explains that part.

    But:

    > However, if you would rather I just removed all of fscache and (most of[*])
    > cachefiles, that I can do.

    I assume and think that if you just do that part first, then the
    "convert to netfslib" of afs and ceph at that later stage will mean
    that the fallback code will never be needed?

    So I would much prefer that streamlined model over one that adds that
    temporary intermediate stage only for it to be deleted.

    Linus

    \
     
     \ /
      Last update: 2021-10-29 20:26    [W:4.706 / U:0.304 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site