Messages in this thread | | | Date | Fri, 29 Oct 2021 14:31:27 +0200 | Subject | Re: [PATCH V7 8/9] trace/osnoise: Remove STACKTRACE ifdefs from inside functions | From | Daniel Bristot de Oliveira <> |
| |
On 10/28/21 23:29, Daniel Bristot de Oliveira wrote: > Remove CONFIG_STACKTRACE from inside functions, avoiding > compilation problems in the future. > > Cc: Steven Rostedt <rostedt@goodmis.org> > Cc: Ingo Molnar <mingo@redhat.com> > Cc: Tom Zanussi <zanussi@kernel.org> > Cc: Masami Hiramatsu <mhiramat@kernel.org> > Cc: Juri Lelli <juri.lelli@redhat.com> > Cc: Clark Williams <williams@redhat.com> > Cc: John Kacur <jkacur@redhat.com> > Cc: Peter Zijlstra <peterz@infradead.org> > Cc: Thomas Gleixner <tglx@linutronix.de> > Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de> > Cc: Daniel Bristot de Oliveira <bristot@kernel.org> > Cc: linux-rt-users@vger.kernel.org > Cc: linux-trace-devel@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Suggested-by: Steven Rostedt <rostedt@goodmis.org> > Signed-off-by: Daniel Bristot de Oliveira <bristot@kernel.org> > --- > kernel/trace/trace_osnoise.c | 44 ++++++++++++++++++++++++------------ > 1 file changed, 29 insertions(+), 15 deletions(-) > > diff --git a/kernel/trace/trace_osnoise.c b/kernel/trace/trace_osnoise.c > index 0c3a93f51b08..eaa6396e3262 100644 > --- a/kernel/trace/trace_osnoise.c > +++ b/kernel/trace/trace_osnoise.c > @@ -635,13 +635,19 @@ __timerlat_dump_stack(struct trace_buffer *buffer, struct trace_stack *fstack, u > /* > * timerlat_dump_stack - dump a stack trace previously saved > */ > -static void timerlat_dump_stack(void) > +static void timerlat_dump_stack(u64 latency) > { > struct osnoise_instance *inst; > struct trace_buffer *buffer; > struct trace_stack *fstack; > unsigned int size; > > + /* > + * 0 is disabled, so it will never be > than latency. > + */ > + if (osnoise_data.print_stack > latency) > + return;
Oops, I placed the comment, but forgot to place the check. This if should be:
if (!osnoise_data.print_stack || osnoise_data.print_stack > latency) return;
-- Daniel
| |