Messages in this thread | | | From | Lukas Bulwahn <> | Date | Fri, 29 Oct 2021 07:53:17 +0200 | Subject | Re: [PATCH 04/13] arm: drop an obsolete ifdef with the removed config PCI_HOST_ITE8152 |
| |
On Thu, Oct 28, 2021 at 5:35 PM Russell King (Oracle) <linux@armlinux.org.uk> wrote: > > On Thu, Oct 28, 2021 at 04:46:38PM +0200, Arnd Bergmann wrote: > > On Thu, Oct 28, 2021 at 4:19 PM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote: > > > > > > Commit 6da5238fa384 ("ARM: 8993/1: remove it8152 PCI controller driver") > > > removes the config PCI_HOST_ITE8152, but left a dangling obsolete ifndef > > > in ./arch/arm/kernel/bios32.c. > > > > > > Hence, ./scripts/checkkconfigsymbols.py warns: > > > > > > PCI_HOST_ITE8152 > > > Referencing files: arch/arm/kernel/bios32.c > > > > > > Remove this obsolete ifndef. > > > > > > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com> > > > > Reviewed-by: Arnd Bergmann <arnd@arndb.de> > > > > I wonder if we should just remove this function and use the > > (non-empty) default version instead. > > > > 96c5590058d7 ("PCI: Pull PCI 'latency timer' setup up into the core") > > introduced that generic version, and I suspect the arm version > > was left out by mistake, but it's not clear from that patch. > > That was because PCI_HOST_ITE8152 needed something different from the > "do nothing" default (setting the PCI latency timer to default to 64 > as the new generic code did.) >
So, can we just drop the empty pcibios_set_master() function in bios32.c and the pci handling will now (after the removal of PCI_HOST_ITE8152) just do The Right Thing(TM)?
If you can confirm that, I will send an updated patch here.
Thanks,
Lukas
| |