lkml.org 
[lkml]   [2021]   [Oct]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 7/8] dt-bindings: phy: uniphier-ahci: Add bindings for Pro4 SoC
From
Date
Hi Rob,

On 2021/10/29 6:12, Rob Herring wrote:
> On Wed, Oct 20, 2021 at 08:58:07AM +0900, Kunihiko Hayashi wrote:
>> Update AHCI-PHY binding document for UniPhier Pro4 SoC. Add a compatible
>> string, clock and reset lines for the SoC to the document.
>>
>> Pro4 AHCI-PHY needs to control additional GIO clock line and reset lines
>> ("pm", "tx", and "rx").
>>
>> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
>> ---
>> .../bindings/phy/socionext,uniphier-ahci-phy.yaml | 20
> ++++++++++++++++----
>> 1 file changed, 16 insertions(+), 4 deletions(-)
>>
>> diff --git
> a/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml
> b/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml
>> index 745c525ce6b9..67415f7ebe8c 100644
>> --- a/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.
> yaml
>> +++ b/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.
> yaml
>> @@ -16,6 +16,7 @@ maintainers:
>> properties:
>> compatible:
>> enum:
>> + - socionext,uniphier-pro4-ahci-phy
>> - socionext,uniphier-pxs2-ahci-phy
>> - socionext,uniphier-pxs3-ahci-phy
>>
>> @@ -30,6 +31,9 @@ properties:
>>
>> clock-names:
>> oneOf:
>> + - items: # for Pro4
>> + - const: gio
>> + - const: link
>
> Add new entries on the end...
>
>> - items: # for PXs2
>> - const: link
>
> So add 'gio' here.
>
> And add 'minItems: 1' in this entry.
>
> There's also an error in 'clocks' as it needs 'minItems: 1'

I see.
I'll add "minItems: 1", and fix the item order.

>
>> - items: # for others
>> @@ -37,12 +41,20 @@ properties:
>> - const: phy
>>
>> resets:
>> - maxItems: 2
>> + minItems: 2
>> + maxItems: 5
>>
>> reset-names:
>> - items:
>> - - const: link
>> - - const: phy
>> + oneOf:
>> + - items: # for Pro4
>> + - const: gio
>> + - const: link
>> + - const: pm
>> + - const: tx
>> + - const: rx
>> + - items: # for others
>> + - const: link
>> + - const: phy
>>
>> required:
>> - compatible
>> --
>> 2.7.4

Thank you,

---
Best Regards
Kunihiko Hayashi

\
 
 \ /
  Last update: 2021-10-29 12:33    [W:0.106 / U:0.764 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site