lkml.org 
[lkml]   [2021]   [Oct]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] wlwifi: Fix missing error code in iwl_pci_probe()
    Date
    From: chongjiapeng <jiapeng.chong@linux.alibaba.com>

    The error code is missing in this code scenario, add the error code
    '-EINVAL' to the return value 'ret'.

    Eliminate the follow smatch warning:

    drivers/net/wireless/intel/iwlwifi/pcie/drv.c:1376 iwl_pci_probe() warn:
    missing error code 'ret'.

    Reported-by: Abaci Robot <abaci@linux.alibaba.com>
    Fixes: 1f171f4f1437 ("iwlwifi: Add support for getting rf id with blank otp")
    Signed-off-by: chongjiapeng <jiapeng.chong@linux.alibaba.com>
    ---
    drivers/net/wireless/intel/iwlwifi/pcie/drv.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/drv.c b/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
    index cff76a528967..33250d24c2b9 100644
    --- a/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
    +++ b/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
    @@ -1442,9 +1442,10 @@ static int iwl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
    */
    if (iwl_trans->trans_cfg->rf_id &&
    iwl_trans->trans_cfg->device_family >= IWL_DEVICE_FAMILY_9000 &&
    - !CSR_HW_RFID_TYPE(iwl_trans->hw_rf_id) && get_crf_id(iwl_trans))
    + !CSR_HW_RFID_TYPE(iwl_trans->hw_rf_id) && get_crf_id(iwl_trans)) {
    ret = -EINVAL;
    goto out_free_trans;
    + }

    dev_info = iwl_pci_find_dev_info(pdev->device, pdev->subsystem_device,
    CSR_HW_REV_TYPE(iwl_trans->hw_rev),
    --
    2.19.1.6.gb485710b
    \
     
     \ /
      Last update: 2021-10-29 11:56    [W:4.083 / U:0.516 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site