Messages in this thread | | | From | Andy Shevchenko <> | Date | Fri, 29 Oct 2021 12:01:57 +0300 | Subject | Re: [PATCH 1/2] media: atomisp: better describe get_frame_info issues |
| |
On Fri, Oct 29, 2021 at 11:50 AM Mauro Carvalho Chehab <mchehab+huawei@kernel.org> wrote: > > When atomisp is used by a normal client, it fails to get > frame info. However, the information is confusing and misleading, > as there are several wrappers for such function, and the error > could be on different places. > > So, improve the error log in order to allow narrowing down > where the error is actually occuring.
...
> + switch (type) { > + case ATOMISP_CSS_VF_FRAME: > + *info = p_info.vf_output_info[0]; > + dev_dbg(isp->dev, "getting vf frame info.\n"); > + break; > + case ATOMISP_CSS_SECOND_VF_FRAME: > + *info = p_info.vf_output_info[1]; > + dev_dbg(isp->dev, "getting second vf frame info.\n"); > + break; > + case ATOMISP_CSS_OUTPUT_FRAME: > + *info = p_info.output_info[0]; > + dev_dbg(isp->dev, "getting main frame info.\n"); > + break; > + case ATOMISP_CSS_SECOND_OUTPUT_FRAME: > + *info = p_info.output_info[1]; > + dev_dbg(isp->dev, "getting second main frame info.\n"); > + break; > + case ATOMISP_CSS_RAW_FRAME: > + *info = p_info.raw_output_info; > + dev_dbg(isp->dev, "getting raw frame info.\n");
Can we get break; here followed by default case?
> } > + dev_dbg(isp->dev, "get frame info: w=%d, h=%d, num_invalid_frames %d.\n", > + info->res.width, info->res.height, p_info.num_invalid_frames); > + > + return 0;
-- With Best Regards, Andy Shevchenko
| |