Messages in this thread Patch in this message | | | Date | Thu, 28 Oct 2021 14:22:13 +0200 | From | Johan Hovold <> | Subject | Re: [PATCH] drivers: tty: replace snprintf in show functions with sysfs_emit |
| |
On Thu, Oct 28, 2021 at 10:13:50AM +0000, cgel.zte@gmail.com wrote: > From: Jing Yao <yao.jing2@zte.com.cn>
Where's the commit message?
Also, look at the log for the driver you're changing for the Subject prefix you should use. Including "drivers:" is never right.
> Reported-by: Zeal Robot <zealci@zte.com.cn> > Signed-off-by: Jing Yao <yao.jing2@zte.com.cn> > --- > drivers/tty/serial/8250/8250_port.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/8250/8250_port.c b/drivers/tty/serial/8250/8250_port.c > index 5775cbff8f6e..557e8b13b5c1 100644 > --- a/drivers/tty/serial/8250/8250_port.c > +++ b/drivers/tty/serial/8250/8250_port.c > @@ -3099,7 +3099,7 @@ static ssize_t rx_trig_bytes_show(struct device *dev, > if (rxtrig_bytes < 0) > return rxtrig_bytes; > > - return snprintf(buf, PAGE_SIZE, "%d\n", rxtrig_bytes); > + return sysfs_emit(buf, PAGE_SIZE, "%d\n", rxtrig_bytes);
FFS... This would not even compile, at least not without a warning, as it's completely broken.
You do know that you have to at least compile-test your patches, right?
> } > > static int do_set_rxtrig(struct tty_port *port, unsigned char bytes)
Johan
| |