lkml.org 
[lkml]   [2021]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    SubjectRe: [PATCH] lib/test_vmalloc.c: use swap() to make code cleaner
    On Thu, Oct 28, 2021 at 11:14:43AM +0000, cgel.zte@gmail.com wrote:
    > From: Changcheng Deng <deng.changcheng@zte.com.cn>
    >
    > Use swap() in order to make code cleaner. Issue found by coccinelle.
    >
    > Reported-by: Zeal Robot <zealci@zte.com.cn>
    > Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn>
    > ---
    > lib/test_vmalloc.c | 6 ++----
    > 1 file changed, 2 insertions(+), 4 deletions(-)
    >
    > diff --git a/lib/test_vmalloc.c b/lib/test_vmalloc.c
    > index e14993bc84d2..cf41fd6df42a 100644
    > --- a/lib/test_vmalloc.c
    > +++ b/lib/test_vmalloc.c
    > @@ -393,7 +393,7 @@ static struct test_driver {
    > static void shuffle_array(int *arr, int n)
    > {
    > unsigned int rnd;
    > - int i, j, x;
    > + int i, j;
    >
    > for (i = n - 1; i > 0; i--) {
    > get_random_bytes(&rnd, sizeof(rnd));
    > @@ -402,9 +402,7 @@ static void shuffle_array(int *arr, int n)
    > j = rnd % i;
    >
    > /* Swap indexes. */
    > - x = arr[i];
    > - arr[i] = arr[j];
    > - arr[j] = x;
    > + swap(arr[i], arr[j]);
    > }
    > }
    >
    > --
    > 2.25.1

    Makes sense to me: Reviewed-by: Uladzislau Rezki (Sony) <urezki@gmail.com>

    --
    Vlad Rezki

    \
     
     \ /
      Last update: 2021-10-28 14:02    [W:3.162 / U:0.220 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site