Messages in this thread | | | From | Rob Herring <> | Date | Thu, 28 Oct 2021 21:07:36 -0500 | Subject | Re: [PATCH 1/1] of: unittest: fix dts for interrupt-map provider build warning |
| |
On Thu, Oct 28, 2021 at 7:58 PM <frowand.list@gmail.com> wrote: > > From: Frank Rowand <frank.rowand@sony.com> > > Fix kernel build warning: > drivers/of/unittest-data/tests-interrupts.dtsi:32.26-35.6: Warning (interrupt_map): /testcase-data/interrupts/intmap1: Missing '#address-cells' in interrupt-map provider > > A recently implemented dtc compiler warning reported the dts problem. > > Signed-off-by: Frank Rowand <frank.rowand@sony.com> > --- > drivers/of/unittest-data/tests-interrupts.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/of/unittest-data/tests-interrupts.dtsi b/drivers/of/unittest-data/tests-interrupts.dtsi > index 9b60a549f502..8c2b91b998aa 100644 > --- a/drivers/of/unittest-data/tests-interrupts.dtsi > +++ b/drivers/of/unittest-data/tests-interrupts.dtsi > @@ -31,6 +31,7 @@ test_intmap0: intmap0 { > > test_intmap1: intmap1 { > #interrupt-cells = <2>; > + #address-cells = <1>;
Notice that we have 2 nodes with interrupt-map here. One has '#address-cells' and one doesn't. Why? Because we need to test that the code can handle both cases.
The dtc warnings are more what should 'new' users do. I don't know what DTs don't have #address-cells, but my guess is ancient ones.
Rob
| |