Messages in this thread | | | Date | Fri, 29 Oct 2021 07:49:15 +0800 | From | kernel test robot <> | Subject | Re: [PATCH] drivers: tty: replace snprintf in show functions with sysfs_emit |
| |
Hi,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on tty/tty-testing] [also build test ERROR on staging/staging-testing v5.15-rc7 next-20211028] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/cgel-zte-gmail-com/drivers-tty-replace-snprintf-in-show-functions-with-sysfs_emit/20211028-181624 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing config: microblaze-buildonly-randconfig-r002-20211028 (attached as .config) compiler: microblaze-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/03b103ac2507a7958ac9e45fe6a53110e1140625 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review cgel-zte-gmail-com/drivers-tty-replace-snprintf-in-show-functions-with-sysfs_emit/20211028-181624 git checkout 03b103ac2507a7958ac9e45fe6a53110e1140625 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=microblaze
If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
In file included from include/linux/mm_types_task.h:16, from include/linux/mm_types.h:5, from include/linux/buildid.h:5, from include/linux/module.h:14, from drivers/tty/serial/8250/8250_port.c:14: drivers/tty/serial/8250/8250_port.c: In function 'rx_trig_bytes_show': >> arch/microblaze/include/asm/page.h:24:25: error: passing argument 2 of 'sysfs_emit' makes pointer from integer without a cast [-Werror=int-conversion] 24 | #define PAGE_SIZE (ASM_CONST(1) << PAGE_SHIFT) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ | | | long unsigned int drivers/tty/serial/8250/8250_port.c:3102:32: note: in expansion of macro 'PAGE_SIZE' 3102 | return sysfs_emit(buf, PAGE_SIZE, "%d\n", rxtrig_bytes); | ^~~~~~~~~ In file included from include/linux/kobject.h:20, from include/linux/module.h:21, from drivers/tty/serial/8250/8250_port.c:14: include/linux/sysfs.h:341:39: note: expected 'const char *' but argument is of type 'long unsigned int' 341 | int sysfs_emit(char *buf, const char *fmt, ...); | ~~~~~~~~~~~~^~~ cc1: all warnings being treated as errors
vim +/sysfs_emit +24 arch/microblaze/include/asm/page.h
4b87d7a4f91d31 Michal Simek 2009-03-27 21 4b87d7a4f91d31 Michal Simek 2009-03-27 22 /* PAGE_SHIFT determines the page size */ ba9c4f88d74783 Steven J. Magnani 2010-05-13 23 #define PAGE_SHIFT 12 ba9c4f88d74783 Steven J. Magnani 2010-05-13 @24 #define PAGE_SIZE (ASM_CONST(1) << PAGE_SHIFT) 4b87d7a4f91d31 Michal Simek 2009-03-27 25 #define PAGE_MASK (~(PAGE_SIZE-1)) 4b87d7a4f91d31 Michal Simek 2009-03-27 26
--- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [unhandled content-type:application/gzip] | |