lkml.org 
[lkml]   [2021]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC PATCH 0/7] Inotify support in FUSE and virtiofs
    On Wed, Oct 27, 2021 at 03:23:19PM +0200, Jan Kara wrote:
    > On Wed 27-10-21 08:59:15, Amir Goldstein wrote:
    > > On Tue, Oct 26, 2021 at 10:14 PM Ioannis Angelakopoulos
    > > <iangelak@redhat.com> wrote:
    > > > On Tue, Oct 26, 2021 at 2:27 PM Vivek Goyal <vgoyal@redhat.com> wrote:
    > > > The problem here is that the OPEN event might still be travelling towards the guest in the
    > > > virtqueues and arrives after the guest has already deleted its local inode.
    > > > While the remote event (OPEN) received by the guest is valid, its fsnotify
    > > > subsystem will drop it since the local inode is not there.
    > > >
    > >
    > > I have a feeling that we are mixing issues related to shared server
    > > and remote fsnotify.
    >
    > I don't think Ioannis was speaking about shared server case here. I think
    > he says that in a simple FUSE remote notification setup we can loose OPEN
    > events (or basically any other) if the inode for which the event happens
    > gets deleted sufficiently early after the event being generated. That seems
    > indeed somewhat unexpected and could be confusing if it happens e.g. for
    > some directory operations.

    Hi Jan,

    Agreed. That's what Ioannis is trying to say. That some of the remote events
    can be lost if fuse/guest local inode is unlinked. I think problem exists
    both for shared and non-shared directory case.

    With local filesystems we have a control that we can first queue up
    the event in buffer before we remove local watches. With events travelling
    from a remote server, there is no such control/synchronization. It can
    very well happen that events got delayed in the communication path
    somewhere and local watches went away and now there is no way to
    deliver those events to the application.

    Thanks
    Vivek

    \
     
     \ /
      Last update: 2021-10-27 22:30    [W:2.925 / U:0.300 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site