lkml.org 
[lkml]   [2021]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 10/16] x86/alternative: Implement .retpoline_sites support
On Tue, Oct 26, 2021 at 02:01:42PM +0200, Peter Zijlstra wrote:
> +static int patch_retpoline(void *addr, struct insn *insn, u8 *bytes)
> +{
> + retpoline_thunk_t *target;
> + int reg, i = 0;
> +
> + target = addr + insn->length + insn->immediate.value;
> + reg = target - __x86_indirect_thunk_array;
> +
> + if (WARN_ON_ONCE(reg & ~0xf))
> + return -1;
> +
> + /* If anyone ever does: CALL/JMP *%rsp, we're in deep trouble. */
> + BUG_ON(reg == 4);
> +
> + if (cpu_feature_enabled(X86_FEATURE_RETPOLINE))
> + return -1;

I wanna say this should be the first thing being checked on function
entry but I get the feeling you'll be looking at other X86_FEATURE bits
in future patches... /me goes into the future...

yap, you do. Lemme look at the whole thing first then.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette

\
 
 \ /
  Last update: 2021-10-27 19:40    [W:0.181 / U:1.912 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site