Messages in this thread | | | Subject | Re: [PATCH v2 10/23] x86/resctrl: Remove architecture copy of mbps_val | From | James Morse <> | Date | Wed, 27 Oct 2021 17:49:54 +0100 |
| |
Hi Reinette,
On 15/10/2021 23:27, Reinette Chatre wrote: > On 10/1/2021 9:02 AM, James Morse wrote: >> The resctrl arch code provides a second configuration array mbps_val[] >> for the MBA software controller. >> >> Since resctrl switched over to allocating and freeing its own array >> when needed, nothing uses the arch code version. > > With the previous changes this is true, that this array is no longer used. Even so, the > code removed in this patch is not just the usage of the array but also its management ... > especially how and when it is reset. While the array is no longer used I think it is still > important to ensure that all the array management is handled in the new mpbs_val array. > Perhaps just help the reader by stating that the values of the new array never needs to be > reset since it is always recreated while the previous array stuck around during umount/mount.
I've split those changes out as a separate patch which appears at the end of the series, meaning the lifecycle stuff is unchanged by this point.
Thanks,
James
| |