Messages in this thread | | | From | Rob Herring <> | Subject | Re: [PATCH v2 2/3] dt-bindings: hwmon: ti,ina2xx: Add ti,shunt-gain property | Date | Wed, 27 Oct 2021 09:12:28 -0500 |
| |
On Wed, 27 Oct 2021 07:42:12 +0000, Nathan Rossi wrote: > From: Nathan Rossi <nathan.rossi@digi.com> > > Add a property to the binding to define the selected shunt voltage gain. > This specifies the range and accuracy that applies to the shunt circuit. > This property only applies to devices that have a selectable shunt > voltage range via PGA or ADCRANGE register configuration. > > Signed-off-by: Nathan Rossi <nathan.rossi@digi.com> > --- > Changes in v2: > - Added binding for shunt-gain > --- > Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) >
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml: properties:ti,shunt-gain: 'oneOf' conditional failed, one must be fixed: 'type' is a required property hint: A vendor boolean property can use "type: boolean" Additional properties are not allowed ('enum' was unexpected) hint: A vendor boolean property can use "type: boolean" /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml: properties:ti,shunt-gain: 'oneOf' conditional failed, one must be fixed: '$ref' is a required property 'allOf' is a required property hint: A vendor property needs a $ref to types.yaml from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml# 1 is not of type 'string' hint: A vendor string property with exact values has an implicit type 2 is not of type 'string' hint: A vendor string property with exact values has an implicit type 4 is not of type 'string' hint: A vendor string property with exact values has an implicit type 8 is not of type 'string' hint: A vendor string property with exact values has an implicit type hint: Vendor specific properties must have a type and description unless they have a defined, common suffix. from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml# /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml: ignoring, error in schema: properties: ti,shunt-gain warning: no schema found in file: ./Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml Documentation/devicetree/bindings/hwmon/ti,ina2xx.example.dt.yaml:0:0: /example-0/i2c/power-sensor@44: failed to match any schema with compatible: ['ti,ina220']
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/1546789
This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:
pip3 install dtschema --upgrade
Please check and re-submit.
| |