Messages in this thread | | | Date | Wed, 27 Oct 2021 07:09:52 -0700 | From | Bjorn Andersson <> | Subject | Re: [PATCH] firmware: qcom: scm: fix non-SMP build |
| |
On Wed 27 Oct 01:49 PDT 2021, Arnd Bergmann wrote:
> On Wed, Oct 27, 2021 at 9:24 AM Arnd Bergmann <arnd@kernel.org> wrote: > > > > From: Arnd Bergmann <arnd@arndb.de> > > > > A check was added for non-arm platforms, but the same code > > is still broken on Arm non-SMP: > > > > ERROR: modpost: "__cpu_logical_map" [drivers/firmware/qcom-scm.ko] undefined! > > > > Fixes: c50031f03dfe ("firmware: qcom: scm: Don't break compile test on non-ARM platforms") > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > Nevermind, this is not sufficient, as the symbol is not actually > exported, so this still > fails on SMP configurations, both 32 and 64 bit. >
Damn, it seems I only compile tested it on the three platforms with configurations where it ended up =y in the end.
> Any ideas for a better fix, or should I revert 55845f46df03 > ("firmware: qcom: scm: > Add support for MC boot address API") for the merge window? >
Let's revert the patch (and the fix) for v5.16 and try to figure this one out for next round.
Regards, Bjorn
| |