lkml.org 
[lkml]   [2021]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/4] arm64: implement support for static call trampolines
On Tue, Oct 26, 2021 at 11:06:11AM +0000, David Laight wrote:
> From: Mark Rutland
> > Sent: 26 October 2021 11:37
> ...
> > My preference overall is to keep the trampoline self-contained, and I'd
> > prefer to keep the RET inline in the trampoline rather than trying to
> > factor it out so that all the control-flow is clearly in one place.
> >
> > So I'd prefer that we have the sequence as-is:
> >
> > | 0: .quad 0x0
> > | bti c
> > | < insn >
> > | ldr x16, 0b
> > | cbz x16, 1f
> > | br x16
> > | 1: ret
>
> What is wrong with:
> 0: .quad 1f
> bti c
> < insn >
> ldr x16, 0b
> br x16
> 1: bti c
> ret
>
> Self-contained and reasonably easy to read.

FWIW, that would work for me too.

Thanks,
Mark.

\
 
 \ /
  Last update: 2021-10-27 14:48    [W:0.140 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site