Messages in this thread | | | Date | Wed, 27 Oct 2021 19:41:37 +0800 | From | kernel test robot <> | Subject | Re: [PATCH 2/4] fs/ntfs3: Restore ntfs_xattr_get_acl and ntfs_xattr_set_acl functions |
| |
Hi Konstantin,
I love your patch! Yet something to improve:
[auto build test ERROR on linux/master] [also build test ERROR on linus/master v5.15-rc7 next-20211026] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Konstantin-Komarov/fs-ntfs3-Various-fixes-for-xattr-and-files/20211027-004353 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 2f111a6fd5b5297b4e92f53798ca086f7c7d33a4 config: nios2-allyesconfig (attached as .config) compiler: nios2-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/8ec3401acda35f5fe1fd4a0c1a5a422e7178acad git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Konstantin-Komarov/fs-ntfs3-Various-fixes-for-xattr-and-files/20211027-004353 git checkout 8ec3401acda35f5fe1fd4a0c1a5a422e7178acad # save the attached .config to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=nios2 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
fs/ntfs3/xattr.c: In function 'ntfs_xattr_get_acl': >> fs/ntfs3/xattr.c:634:15: error: too few arguments to function 'ntfs_get_acl' 634 | acl = ntfs_get_acl(inode, type); | ^~~~~~~~~~~~ fs/ntfs3/xattr.c:533:19: note: declared here 533 | struct posix_acl *ntfs_get_acl(struct inode *inode, int type, bool rcu) | ^~~~~~~~~~~~
vim +/ntfs_get_acl +634 fs/ntfs3/xattr.c
621 622 static int ntfs_xattr_get_acl(struct user_namespace *mnt_userns, 623 struct inode *inode, int type, void *buffer, 624 size_t size) 625 { 626 struct posix_acl *acl; 627 int err; 628 629 if (!(inode->i_sb->s_flags & SB_POSIXACL)) { 630 ntfs_inode_warn(inode, "add mount option \"acl\" to use acl"); 631 return -EOPNOTSUPP; 632 } 633 > 634 acl = ntfs_get_acl(inode, type); 635 if (IS_ERR(acl)) 636 return PTR_ERR(acl); 637 638 if (!acl) 639 return -ENODATA; 640 641 err = posix_acl_to_xattr(mnt_userns, acl, buffer, size); 642 posix_acl_release(acl); 643 644 return err; 645 } 646
--- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [unhandled content-type:application/gzip] | |