lkml.org 
[lkml]   [2021]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] platform/x86: remove duplicate include in barco-p50-gpio.c
Date
>>>>> "cgel" == cgel zte <cgel.zte@gmail.com> writes:

> From: ran jianping <ran.jianping@zte.com.cn>
> 'linux/io.h' included in 'drivers/platform/x86/barco-p50-gpio.c'
> is duplicated.It is also included on the 17 line.

> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: ran jianping <ran.jianping@zte.com.cn>
> ---
> drivers/platform/x86/barco-p50-gpio.c | 1 -
> 1 file changed, 1 deletion(-)

> diff --git a/drivers/platform/x86/barco-p50-gpio.c b/drivers/platform/x86/barco-p50-gpio.c
> index f5c72e33f9ae..bb8ed8e95225 100644
> --- a/drivers/platform/x86/barco-p50-gpio.c
> +++ b/drivers/platform/x86/barco-p50-gpio.c
> @@ -14,7 +14,6 @@
> #include <linux/delay.h>
> #include <linux/dmi.h>
> #include <linux/err.h>
> -#include <linux/io.h>

It probably makes more sense to drop the include from line 17 to keep
alphabetical ordering, but otherwise it looks good to.

With that fixed:

Acked-by: Peter Korsgaard <peter@korsgaard.com>

--
Bye, Peter Korsgaard

\
 
 \ /
  Last update: 2021-10-27 10:21    [W:0.109 / U:0.260 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site