Messages in this thread Patch in this message | | | From | Jiasheng Jiang <> | Subject | [PATCH] thermal: Fix implicit type conversion | Date | Thu, 28 Oct 2021 03:21:32 +0000 |
| |
The parameter 'cpu' is defined as unsigned int. However in the cpumask_next() it is implicitly type conversed to int. It is universally accepted that the implicit type conversion is terrible. Also, having the good programming custom will set an example for others. Thus, it might be better to change the type of 'cpu' from unsigned int to int.
Fixes: 3e8c4d3 ("drivers: thermal: Move various drivers for intel platforms into a subdir") Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn> --- drivers/thermal/intel/intel_powerclamp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/intel/intel_powerclamp.c b/drivers/thermal/intel/intel_powerclamp.c index b0eb5ec..ed46b5e 100644 --- a/drivers/thermal/intel/intel_powerclamp.c +++ b/drivers/thermal/intel/intel_powerclamp.c @@ -578,7 +578,7 @@ static int powerclamp_cpu_online(unsigned int cpu) return 0; } -static int powerclamp_cpu_predown(unsigned int cpu) +static int powerclamp_cpu_predown(int cpu) { if (clamping == false) return 0; -- 2.7.4
| |