Messages in this thread | | | From | David Gow <> | Date | Thu, 28 Oct 2021 07:02:45 +0800 | Subject | Re: [PATCH v2 1/4] kunit: tool: Do not error on tests without test plans |
| |
On Thu, Oct 28, 2021 at 6:13 AM Daniel Latypov <dlatypov@google.com> wrote: > > On Tue, Oct 26, 2021 at 6:37 PM David Gow <davidgow@google.com> wrote: > > > > The (K)TAP spec encourages test output to begin with a 'test plan': a > > count of the number of tests being run of the form: > > 1..n > > > > However, some test suites might not know the number of subtests in > > advance (for example, KUnit's parameterised tests use a generator > > function). In this case, it's not possible to print the test plan in > > advance. > > > > kunit_tool already parses test output which doesn't contain a plan, but > > reports an error. Since we want to use nested subtests with KUnit > > paramterised tests, remove this error. > > > > Signed-off-by: David Gow <davidgow@google.com> > > Reviewed-by: Daniel Latypov <dlatypov@google.com> > > This looks to be unchanged from v1.
Yeah, the changes in v2 were all in the new patches.
-- David
| |