Messages in this thread | | | Date | Wed, 27 Oct 2021 12:26:01 +0800 | Subject | Re: [PATCH v2] f2fs: compress: disallow disabling compress on non-empty compressed file | From | Chao Yu <> |
| |
On 2021/10/27 12:16, Hyeong-Jun Kim wrote: > Compresse file and normal file has differ in i_addr addressing, > specifically addrs per inode/block. So, we will face data loss, if we > disable the compression flag on non-empty files. Therefore we should > disallow not only enabling but disabling the compression flag on > non-empty files. > > --- > v2: > - check F2FS_HAS_BLOCKS() instead of i_size > > Fixes: 4c8ff7095bef ("f2fs: support data compression") > Signed-off-by: Sungjong Seo <sj1557.seo@samsung.com> > Signed-off-by: Hyeong-Jun Kim <hj514.kim@samsung.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Thanks,
| |