lkml.org 
[lkml]   [2021]   [Oct]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] phy: stm32: adopt dev_err_probe for regulators
From
Date
Hi Fabrice,

Thanks for your patch.

On 10/25/21 4:31 PM, Fabrice Gasnier wrote:
> Change stm32-usbphyc driver to use dev_err_probe(), to benefit of
> devices_deferred debugfs in case of probe deferral.
> > Signed-off-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>

Reviewed-by: Amelie Delaunay <amelie.delaunay@foss.st.com>

> ---
> drivers/phy/st/phy-stm32-usbphyc.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/phy/st/phy-stm32-usbphyc.c b/drivers/phy/st/phy-stm32-usbphyc.c
> index 7df6a63..115be0e 100644
> --- a/drivers/phy/st/phy-stm32-usbphyc.c
> +++ b/drivers/phy/st/phy-stm32-usbphyc.c
> @@ -672,17 +672,15 @@ static int stm32_usbphyc_probe(struct platform_device *pdev)
>
> usbphyc->vdda1v1 = devm_regulator_get(dev, "vdda1v1");
> if (IS_ERR(usbphyc->vdda1v1)) {
> - ret = PTR_ERR(usbphyc->vdda1v1);
> - if (ret != -EPROBE_DEFER)
> - dev_err(dev, "failed to get vdda1v1 supply: %d\n", ret);
> + ret = dev_err_probe(dev, PTR_ERR(usbphyc->vdda1v1),
> + "failed to get vdda1v1 supply\n");
> goto clk_disable;
> }
>
> usbphyc->vdda1v8 = devm_regulator_get(dev, "vdda1v8");
> if (IS_ERR(usbphyc->vdda1v8)) {
> - ret = PTR_ERR(usbphyc->vdda1v8);
> - if (ret != -EPROBE_DEFER)
> - dev_err(dev, "failed to get vdda1v8 supply: %d\n", ret);
> + ret = dev_err_probe(dev, PTR_ERR(usbphyc->vdda1v8),
> + "failed to get vdda1v8 supply\n");
> goto clk_disable;
> }
>
>

\
 
 \ /
  Last update: 2021-10-26 17:52    [W:0.052 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site