Messages in this thread | | | Date | Tue, 26 Oct 2021 14:30:37 +0200 | From | Johan Hovold <> | Subject | Re: [PATCH net v2] usbnet: fix error return code in usbnet_probe() |
| |
On Tue, Oct 26, 2021 at 08:40:15PM +0800, Wang Hai wrote: > Return error code if usb_maxpacket() returns 0 in usbnet_probe() > > Fixes: 397430b50a36 ("usbnet: sanity check for maxpacket") > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Wang Hai <wanghai38@huawei.com>
This needs to go to stable as well as the offending patch is being backported.
Cc: stable@vger.kernel.org Reviewed-by: Johan Hovold <johan@kernel.org>
> --- > v1->v2: change '-EINVAL' to '-ENODEV' > drivers/net/usb/usbnet.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c > index 80432ee0ce69..a33d7fb82a00 100644 > --- a/drivers/net/usb/usbnet.c > +++ b/drivers/net/usb/usbnet.c > @@ -1790,6 +1790,7 @@ usbnet_probe (struct usb_interface *udev, const struct usb_device_id *prod) > dev->maxpacket = usb_maxpacket (dev->udev, dev->out, 1); > if (dev->maxpacket == 0) { > /* that is a broken device */ > + status = -ENODEV; > goto out4; > }
Johan
| |