lkml.org 
[lkml]   [2021]   [Oct]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 4/4] thermal: k3_j72xx_bandgap: Add the bandgap driver support
Hi Keerthy,

I love your patch! Perhaps something to improve:

[auto build test WARNING on robh/for-next]
[also build test WARNING on rafael-pm/thermal v5.15-rc7 next-20211025]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Keerthy/thermal-k3_j72xx_bandgap-Add-the-bandgap-driver-support/20211026-021100
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: h8300-buildonly-randconfig-r002-20211026 (attached as .config)
compiler: h8300-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/a60ffd2edff44c1ee199aa7ad3b847815aad93e7
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Keerthy/thermal-k3_j72xx_bandgap-Add-the-bandgap-driver-support/20211026-021100
git checkout a60ffd2edff44c1ee199aa7ad3b847815aad93e7
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=h8300

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/thermal/k3_j72xx_bandgap.c:97:6: warning: no previous prototype for 'init_table' [-Wmissing-prototypes]
97 | void init_table(bool wa, int *mytable)
| ^~~~~~~~~~
drivers/thermal/k3_j72xx_bandgap.c: In function 'prep_lookup_table':
drivers/thermal/k3_j72xx_bandgap.c:148:13: warning: variable 'start_temp' set but not used [-Wunused-but-set-variable]
148 | int start_temp, inc, i;
| ^~~~~~~~~~
drivers/thermal/k3_j72xx_bandgap.c: At top level:
drivers/thermal/k3_j72xx_bandgap.c:227:5: warning: no previous prototype for 'two_cmp' [-Wmissing-prototypes]
227 | int two_cmp(int tmp, int mask)
| ^~~~~~~


vim +/init_table +97 drivers/thermal/k3_j72xx_bandgap.c

96
> 97 void init_table(bool wa, int *mytable)
98 {
99 s64 *factors;
100 const int size = 1024;
101 int factors_size;
102 int i;
103
104 if (wa) {
105 factors_size = 3;
106 factors = pvt_wa_factors;
107 } else {
108 factors_size = 5;
109 factors = golden_factors;
110 }
111
112 for (i = 0; i < size; i++)
113 mytable[i] = compute_value(i, factors, factors_size, 13);
114 }
115

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[unhandled content-type:application/gzip]
\
 
 \ /
  Last update: 2021-10-26 12:52    [W:0.105 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site