lkml.org 
[lkml]   [2021]   [Oct]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] io-wq: Remove unnecessary rcu_read_lock/unlock() in raw spinlock critical section
On Tue, Oct 26, 2021 at 11:23 AM Zqiang <qiang.zhang1211@gmail.com> wrote:
>
> Due to raw_spin_lock/unlock() contains preempt_disable/enable() action,
> already regarded as RCU critical region, so remove unnecessary
> rcu_read_lock/unlock().
>
> Signed-off-by: Zqiang <qiang.zhang1211@gmail.com>
> ---
> fs/io-wq.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/io-wq.c b/fs/io-wq.c
> index cd88602e2e81..401be005d089 100644
> --- a/fs/io-wq.c
> +++ b/fs/io-wq.c
> @@ -855,9 +855,7 @@ static void io_wqe_enqueue(struct io_wqe *wqe, struct io_wq_work *work)
> io_wqe_insert_work(wqe, work);
> clear_bit(IO_ACCT_STALLED_BIT, &acct->flags);
>
> - rcu_read_lock();

Add a comment like:
/* spin_lock can serve as an RCU read-side critical section. */

With that.

Reviewed-by: Muchun Song <songmuchun@bytedance.com>

Thanks.

> do_create = !io_wqe_activate_free_worker(wqe, acct);
> - rcu_read_unlock();
>
> raw_spin_unlock(&wqe->lock);
>
> --
> 2.17.1
>

\
 
 \ /
  Last update: 2021-10-26 12:33    [W:0.046 / U:0.224 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site