Messages in this thread | | | Subject | Re: 回复: driver/bug: suspected missing null check in hisi lpc.c | From | John Garry <> | Date | Tue, 26 Oct 2021 11:32:38 +0100 |
| |
On 25/10/2021 16:31, YE Chengfeng wrote: > It is driver/bus, sorry for the typo. > > -----邮件原件----- > 发件人: YE Chengfeng > 发送时间: 2021年10月25日 23:22 > 收件人: linux-kernel@vger.kernel.org; john.garry@huawei.com > 主题: driver/bug: suspected missing null check in hisi_lpc.c > > Hi, > > https://github.com/torvalds/linux/blob/master/drivers/bus/hisi_lpc.c#L483 > > Our experimental static analysis tool detects a null-ptr-reference problem. It could be false positive, we report this to you just in case. > > Null check is missing for the return pointer of ACPI_COMPANION at line 483 and line 504. It seems that there could be potential null-ptr-dereference problem at line 488 and line 509. Could you spare some time to have a look at it? > > Thanks so much, > Chengfeng >
I don't think that we should have a problem as ACPI_COMPANION() should just not return NULL for us. But I can't give you a better reason than that without fully examining the ACPI code, which I'm not keen on...
Thanks, John
| |