Messages in this thread | | | Date | Tue, 26 Oct 2021 09:59:34 +0100 | From | "Russell King (Oracle)" <> | Subject | Re: [PATCH] ARM: add BUILD_BUG_ON to check if fixmap range spans multiple pmds |
| |
On Sun, Oct 24, 2021 at 11:44:31PM +0200, Linus Walleij wrote: > On Wed, Oct 20, 2021 at 7:50 AM <quanyang.wang@windriver.com> wrote: > > > From: Quanyang Wang <quanyang.wang@windriver.com> > > > > Not only the early fixmap range, but also the fixmap range should be > > checked if it spans multiple pmds. When enabling CONFIG_DEBUG_HIGHMEM, > > some systems which contain up to 16 CPUs will crash. > > > > Signed-off-by: Quanyang Wang <quanyang.wang@windriver.com> > > Looks reasonable to me. > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > > Please submit this patch into Russell's patch tracker.
... and has totally broken what looks like _all_ ARM kernel builds. It can not have been tested. Maybe it's uncovered a previously unknown problem, but causing such a wide-range regression is disappointing. I'm going to revert this commit.
-- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
| |