lkml.org 
[lkml]   [2021]   [Oct]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH V5 04/20] trace/osnoise: Use start/stop_per_cpu_kthreads() on osnoise_cpus_write()
From
On 10/26/21 03:08, Steven Rostedt wrote:
> On Mon, 25 Oct 2021 19:40:29 +0200
> Daniel Bristot de Oliveira <bristot@kernel.org> wrote:
>
>> When writing a new CPU mask via osnoise/cpus, if the tracer is running,
>> the workload is restarted to follow the new cpumask. The restart is
>> currently done using osnoise_workload_start/stop(), which disables the
>> workload *and* the instrumentation. However, disabling the
>> instrumentation is not necessary.
>>
>> Calling start/stop_per_cpu_kthreads() is enough to apply the new
>> osnoise/cpus config.
>>
>> No functional change.
>
> I nuked the "No functional change.". You can't have the changes of the
> above and say there wasn't functional changes, as the first paragraph
> explains the functional changes.

ack, /me takes note.

-- Daniel
>
> -- Steve
>

\
 
 \ /
  Last update: 2021-10-26 10:24    [W:0.065 / U:0.184 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site