Messages in this thread | | | Subject | Re: [PATCH v2] xen: Fix implicit type conversion | From | Juergen Gross <> | Date | Tue, 26 Oct 2021 09:36:23 +0200 |
| |
On 26.10.21 09:32, Jiasheng Jiang wrote: > The variable 'i' is defined as UINT. > However in the for_each_possible_cpu, its value is assigned to -1. > That doesn't make sense and in the cpumask_next() it is implicitly > type conversed to INT. > It is universally accepted that the implicit type conversion is > terrible. > Also, having the good programming custom will set an example for > others. > Thus, it might be better to change the definition of 'i' from UINT > to INT. > > Fixes: 3fac101 ("xen: Re-upload processor PM data to hypervisor after S3 resume (v2)") > Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen
[unhandled content-type:application/pgp-keys][unhandled content-type:application/pgp-signature] | |