lkml.org 
[lkml]   [2021]   [Oct]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] drivers: mtd: Fixed breaking list in __mtd_del_partition.
Hi Andreas,

ennoerlangen@gmail.com wrote on Mon, 25 Oct 2021 22:57:24 +0200:

> Not the child partition should be removed from the partition list
> but the partition itself. Otherwise the partition list gets broken
> and any subsequent remove operations leads to a kernel panic.
>

Can you please Add a couple of Fixes: + Cc: stable tags?

> Signed-off-by: Andreas Oetken <andreas.oetken@siemens-energy.com>
> ---
> drivers/mtd/mtdpart.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/mtdpart.c b/drivers/mtd/mtdpart.c
> index 95d47422bbf20..5725818fa199f 100644
> --- a/drivers/mtd/mtdpart.c
> +++ b/drivers/mtd/mtdpart.c
> @@ -313,7 +313,7 @@ static int __mtd_del_partition(struct mtd_info *mtd)
> if (err)
> return err;
>
> - list_del(&child->part.node);
> + list_del(&mtd->part.node);
> free_partition(mtd);
>
> return 0;


Thanks,
Miquèl

\
 
 \ /
  Last update: 2021-10-26 09:33    [W:0.037 / U:0.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site