lkml.org 
[lkml]   [2021]   [Oct]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH -next] virtio-pci: fix error return code in vp_legacy_probe()
On Tue, Oct 26, 2021 at 9:39 PM Yang Yingliang <yangyingliang@huawei.com> wrote:
>
> Return error code if pci_iomap() fails in vp_legacy_probe()
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: c3ca8a3eeb54 ("virtio-pci: introduce legacy device module")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---

Acked-by: Jason Wang <jasowang@redhat.com>

> drivers/virtio/virtio_pci_legacy_dev.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/virtio/virtio_pci_legacy_dev.c b/drivers/virtio/virtio_pci_legacy_dev.c
> index 9b97680dd02b..4ca3ef38d3bf 100644
> --- a/drivers/virtio/virtio_pci_legacy_dev.c
> +++ b/drivers/virtio/virtio_pci_legacy_dev.c
> @@ -45,8 +45,10 @@ int vp_legacy_probe(struct virtio_pci_legacy_device *ldev)
> return rc;
>
> ldev->ioaddr = pci_iomap(pci_dev, 0, 0);
> - if (!ldev->ioaddr)
> + if (!ldev->ioaddr) {
> + rc = -ENOMEM;
> goto err_iomap;
> + }
>
> ldev->isr = ldev->ioaddr + VIRTIO_PCI_ISR;
>
> --
> 2.25.1
>

\
 
 \ /
  Last update: 2021-10-27 04:37    [W:0.031 / U:0.656 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site