lkml.org 
[lkml]   [2021]   [Oct]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 1/1] riscv: defconfig: enable DRM_NOUVEAU
Date
On 2021/10/27 8:58, Palmer Dabbelt wrote:
> On Tue, 12 Oct 2021 09:46:58 PDT (-0700), heinrich.schuchardt@canonical.com wrote:
>> Both RADEON and NOUVEAU graphics cards are supported on RISC-V. Enabling
>> the one and not the other does not make sense.
>>
>> As typically at most one of RADEON, NOUVEAU, or VIRTIO GPU support will be
>> needed DRM drivers should be compiled as modules.
>
> Do you have an nVidia card that works on real hardware? Last I checked
> was a while ago, but they weren't working at the time (IIRC it was
> something to do with PCIe addressing, but it was a hardware limitation
> so I don't remember exactly how it all fits together).
>
> If they work then I'm happy to flip them on.

Why enable this at all ? If they do not work, then disabling theses cards make
sense. But if they do work, isn't leaving the config to be the default defined
by the driver the preferred approach ? Otherwise, we will eventually end-up with
a defconfig that has everything enabled...

>
>> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
>> ---
>> arch/riscv/configs/defconfig | 7 ++++---
>> 1 file changed, 4 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/riscv/configs/defconfig b/arch/riscv/configs/defconfig
>> index 4ebc80315f01..c252fd5706d2 100644
>> --- a/arch/riscv/configs/defconfig
>> +++ b/arch/riscv/configs/defconfig
>> @@ -72,9 +72,10 @@ CONFIG_GPIOLIB=y
>> CONFIG_GPIO_SIFIVE=y
>> # CONFIG_PTP_1588_CLOCK is not set
>> CONFIG_POWER_RESET=y
>> -CONFIG_DRM=y
>> -CONFIG_DRM_RADEON=y
>> -CONFIG_DRM_VIRTIO_GPU=y
>> +CONFIG_DRM=m
>> +CONFIG_DRM_RADEON=m
>> +CONFIG_DRM_NOUVEAU=m
>> +CONFIG_DRM_VIRTIO_GPU=m
>> CONFIG_FRAMEBUFFER_CONSOLE=y
>> CONFIG_USB=y
>> CONFIG_USB_XHCI_HCD=y
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
>


--
Damien Le Moal
Western Digital Research

\
 
 \ /
  Last update: 2021-10-27 04:32    [W:0.170 / U:0.464 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site