Messages in this thread | | | From | Abhyuday Godhasara <> | Subject | RE: [PATCH v6 1/6] firmware: xilinx: add register notifier in zynqmp firmware | Date | Tue, 26 Oct 2021 07:19:56 +0000 |
| |
Hi Greg,
> -----Original Message----- > From: Abhyuday Godhasara > Sent: Monday, October 25, 2021 5:42 PM > To: 'Greg KH' <gregkh@linuxfoundation.org> > Cc: Michal Simek <michals@xilinx.com>; Rajan Vaja <RAJANV@xilinx.com>; > Manish Narani <MNARANI@xilinx.com>; zou_wei@huawei.com; Sai Krishna > Potthuri <lakshmis@xilinx.com>; Jiaying Liang <jliang@xilinx.com>; linux- > kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; Tejas Patel > <TEJASP@xilinx.com> > Subject: RE: [PATCH v6 1/6] firmware: xilinx: add register notifier in zynqmp > firmware > > Hi Greg, > > > -----Original Message----- > > From: Greg KH <gregkh@linuxfoundation.org> > > Sent: Monday, October 25, 2021 5:33 PM > > To: Abhyuday Godhasara <agodhasa@xilinx.com> > > Cc: Michal Simek <michals@xilinx.com>; Rajan Vaja <RAJANV@xilinx.com>; > > Manish Narani <MNARANI@xilinx.com>; zou_wei@huawei.com; Sai Krishna > > Potthuri <lakshmis@xilinx.com>; Jiaying Liang <jliang@xilinx.com>; > > linux- kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > > Tejas Patel <TEJASP@xilinx.com> > > Subject: Re: [PATCH v6 1/6] firmware: xilinx: add register notifier in > > zynqmp firmware > > > > On Mon, Oct 25, 2021 at 11:53:17AM +0000, Abhyuday Godhasara wrote: > > > Hi Greg, > > > > > > > -----Original Message----- > > > > From: Greg KH <gregkh@linuxfoundation.org> > > > > Sent: Monday, October 25, 2021 2:05 PM > > > > To: Abhyuday Godhasara <agodhasa@xilinx.com> > > > > Cc: Michal Simek <michals@xilinx.com>; Rajan Vaja > > > > <RAJANV@xilinx.com>; Manish Narani <MNARANI@xilinx.com>; > > > > zou_wei@huawei.com; Sai Krishna Potthuri <lakshmis@xilinx.com>; > > > > Jiaying Liang <jliang@xilinx.com>; Jiaying Liang > > > > <jliang@xilinx.com>; linux-kernel@vger.kernel.org; linux-arm- > > > > kernel@lists.infradead.org; Tejas Patel <TEJASP@xilinx.com> > > > > Subject: Re: [PATCH v6 1/6] firmware: xilinx: add register > > > > notifier in zynqmp firmware > > > > > > > > On Mon, Oct 25, 2021 at 01:23:45AM -0700, Abhyuday Godhasara wrote: > > > > > In zynqmp-firmware, register notifier is not supported, add > > > > > support of register notifier in zynqmp-firmware. > > > > > > > > > > Signed-off-by: Tejas Patel <tejas.patel@xilinx.com> > > > > > Signed-off-by: Abhyuday Godhasara > > > > > <abhyuday.godhasara@xilinx.com> > > > > > Acked-by: Michal Simek <michal.simek@xilinx.com> > > > > > --- > > > > > Changes in v6: > > > > > - Minor fix > > > > > > > > > > > > That is vague, what got "fixed" here? > > > [Abhyuday] During rebase of patches on your tree couple of lines > > > code was > > get mixed unintendedly in xlnx-zynqmp.h header file due to use of "git am - > 3". > > > I corrected the below code which was wrong in previous patch v5. > > > +static inline int zynqmp_pm_register_notifier(const u32 node, const > > > +u32 > > event, > > > + const u32 wake, const u32 enable) > > { > > > + return -ENODEV; > > > +} > > > > > > In v5 it was like below, which is wrong static inline int > > > zynqmp_pm_load_pdi(const u32 src, const u64 address) static inline > > > int zynqmp_pm_register_notifier(const u32 node, const u32 event, > > > const u32 wake, const u32 enable) > > { > > > return -ENODEV; > > > } > > > So, the body was missing here for zynqmp_pm_load_pdi in v5. > > > > And why did you not describe this in the changelog text? That is what > > I was asking about here. Please be specific, as reviewers need to > > know this type of thing. > [Abhyuday] Just to avoid longer change log I added it as "Minor fix" this time, > but will be taken care this type of things from next time. > Are you expecting the v7 for this time ? [Abhyuday] Submitted v7 with updated cover latter and version history as per suggestion.
Thanks, Abhyuday
> > Thanks, > Abhyuday > > > > > thanks, > > > > greg k-h
| |