lkml.org 
[lkml]   [2021]   [Oct]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] dt-bindings: usb: dwc2: document the port when usb-role-switch is used
On Wed, Oct 13, 2021 at 06:53:46PM +0200, Fabrice Gasnier wrote:
> Document the "port" property, which is used with "usb-role-switch"
> to describe the bus connector.
> Definition is inspired from mediatek,mtu3.yaml.
>
> This fixes some errors seen when running "make dtbs_check":
> ... 'port' does not match any of the regexes: 'pinctrl-[0-9]+'
> From schema: ... Documentation/devicetree/bindings/usb/dwc2.yaml
>
> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
> ---
> Documentation/devicetree/bindings/usb/dwc2.yaml | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/dwc2.yaml b/Documentation/devicetree/bindings/usb/dwc2.yaml
> index 10c7d9b..7d1aa53 100644
> --- a/Documentation/devicetree/bindings/usb/dwc2.yaml
> +++ b/Documentation/devicetree/bindings/usb/dwc2.yaml
> @@ -130,6 +130,16 @@ properties:
> description: If present indicates that we need to reset the PHY when we
> detect a wakeup. This is due to a hardware errata.
>
> + port:
> + description:
> + Any connector to the data bus of this controller should be modelled
> + using the OF graph bindings specified, if the "usb-role-switch"
> + property is used. See graph.txt

Drop 'See graph.txt'

> + $ref: /schemas/graph.yaml#/properties/port
> +
> +dependencies:
> + port: [ 'usb-role-switch' ]

usb-role-switch without port is valid or both must be present. In case
of the latter, you need to add:

usb-role-switch: [ port ]

Also, you don't need quotes.

> +
> required:
> - compatible
> - reg
> --
> 2.7.4
>
>

\
 
 \ /
  Last update: 2021-10-26 22:38    [W:0.068 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site