lkml.org 
[lkml]   [2021]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [net-next PATCH] net: convert users of bitmap_foo() to linkmode_foo()
From
Date


On 10/24/21 2:50 PM, Andrew Lunn wrote:
> On Fri, Oct 22, 2021 at 06:41:04PM -0400, Sean Anderson wrote:
>> This converts instances of
>> bitmap_foo(args..., __ETHTOOL_LINK_MODE_MASK_NBITS)
>> to
>> linkmode_foo(args...)
>
> It does touch a lot of files, but it does help keep the API uniform.
>
>> I manually fixed up some lines to prevent them from being excessively
>> long. Otherwise, this change was generated with the following semantic
>> patch:
>
> How many did you fix?

Around 3 hunks. For example, in mlx4 the original is

if (bitmap_intersects(
ptys2ethtool_link_mode(&ptys2ethtool_map[i],
report),
link_modes,
__ETHTOOL_LINK_MODE_MASK_NBITS))

which was originally converted as

if (linkmode_intersects(ptys2ethtool_link_mode(&ptys2ethtool_map[i],
report),
link_modes))

and which I rewrote as

ulong *map_mode = ptys2ethtool_link_mode(&ptys2ethtool_map[i],
report);
if (linkmode_intersects(map_mode, link_modes))

(although upon further review it seems like there should be an
additional blank line there)

Everything I changed should be caught by checkpatch.

--Sean

>
>> Because this touches so many files in the net tree, you may want to
>> generate a new diff using the semantic patch above when you apply this.
>
> If it still applies cleanly, i would just apply it. Otherwise maybe
> Jakub could recreate it?
>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
>
> Andrew
>

\
 
 \ /
  Last update: 2021-10-25 17:07    [W:1.088 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site