Messages in this thread | | | Date | Mon, 25 Oct 2021 16:59:25 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH v6 2/4] drivers/acpi: Introduce Platform Firmware Runtime Update device driver |
| |
On Mon, Oct 25, 2021 at 10:11:11PM +0800, Chen Yu wrote: > > > +module_init(pfru_init); > > > +module_exit(pfru_exit); > > > > module_platform_driver()? > > > Currently there are two platform drivers in this file, one is this > platform driver, another one will be introduced in the subsequent > patch for telemetry. Since the two platform drivers are treated > as a whole, they are put into one file. Should I split them > into two files?
If they bind to different hardware devices, then yes, they should be separate files as they are not sharing any common code here.
thanks,
greg k-h
| |