lkml.org 
[lkml]   [2021]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 3/3] refscale: always log the error message
Date


On 25/10/2021 11:26, Li Zhijian wrote:
> Generally, error message should be logged anyhow.
>
> Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
> ---
> kernel/rcu/refscale.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/kernel/rcu/refscale.c b/kernel/rcu/refscale.c
> index a4479f00dcdc..f055d168365a 100644
> --- a/kernel/rcu/refscale.c
> +++ b/kernel/rcu/refscale.c
> @@ -58,8 +58,8 @@ do { \
> } \
> } while (0)
>
> -#define VERBOSE_SCALEOUT_ERRSTRING(s, x...) \
> - do { if (verbose) pr_alert("%s" SCALE_FLAG "!!! " s, scale_type, ## x); } while (0)
> +#define SCALEOUT_ERRSTRING(s, x...) \
> + do { pr_alert("%s" SCALE_FLAG "!!! " s, scale_type, ## x); } while (0)
>
> MODULE_LICENSE("GPL");
> MODULE_AUTHOR("Joel Fernandes (Google) <joel@joelfernandes.org>");
> @@ -651,7 +651,7 @@ static int main_func(void *arg)
> result_avg = kzalloc(nruns * sizeof(*result_avg), GFP_KERNEL);
> buf = kzalloc(800 + 64, GFP_KERNEL);
> if (!result_avg || !buf) {
> - VERBOSE_SCALEOUT_ERRSTRING("out of memory");
> + SCALEOUT_ERRSTRING("out of memory");

'\n' should be added to the last to flush it.



> goto oom_exit;
> }
> if (holdoff)
> @@ -837,7 +837,7 @@ ref_scale_init(void)
> reader_tasks = kcalloc(nreaders, sizeof(reader_tasks[0]),
> GFP_KERNEL);
> if (!reader_tasks) {
> - VERBOSE_SCALEOUT_ERRSTRING("out of memory");
> + SCALEOUT_ERRSTRING("out of memory");
ditto

Thanks
Zhijian
> firsterr = -ENOMEM;
> goto unwind;
> }
\
 
 \ /
  Last update: 2021-10-25 08:13    [W:0.079 / U:0.804 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site