lkml.org 
[lkml]   [2021]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH v1 5/5] tty: rpmsg: Define tty name via constant string literal
Date
Driver uses already twice the same string literal.

Define it in one place, so every user will have this
name consistent.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/tty/rpmsg_tty.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/tty/rpmsg_tty.c b/drivers/tty/rpmsg_tty.c
index 4bee6c5bbb53..dae2a4e44f38 100644
--- a/drivers/tty/rpmsg_tty.c
+++ b/drivers/tty/rpmsg_tty.c
@@ -18,6 +18,7 @@
#include <linux/tty.h>
#include <linux/tty_flip.h>

+#define RPMSG_TTY_NAME "ttyRPMSG"
#define MAX_TTY_RPMSG 32

static DEFINE_IDR(tty_idr); /* tty instance id */
@@ -172,7 +173,7 @@ static int rpmsg_tty_probe(struct rpmsg_device *rpdev)

dev_set_drvdata(dev, cport);

- dev_dbg(dev, "New channel: 0x%x -> 0x%x : ttyRPMSG%d\n",
+ dev_dbg(dev, "New channel: 0x%x -> 0x%x: " RPMSG_TTY_NAME "%d\n",
rpdev->src, rpdev->dst, cport->id);

return 0;
@@ -224,7 +225,7 @@ static int __init rpmsg_tty_init(void)
return PTR_ERR(rpmsg_tty_driver);

rpmsg_tty_driver->driver_name = "rpmsg_tty";
- rpmsg_tty_driver->name = "ttyRPMSG";
+ rpmsg_tty_driver->name = RPMSG_TTY_NAME;
rpmsg_tty_driver->major = 0;
rpmsg_tty_driver->type = TTY_DRIVER_TYPE_CONSOLE;

--
2.33.0
\
 
 \ /
  Last update: 2021-10-25 15:53    [W:0.176 / U:0.572 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site