lkml.org 
[lkml]   [2021]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] ASoC: tegra: Add master volume/mute control support
From
On 25. 10. 21 13:06, Sameer Pujar wrote:

> @@ -150,11 +186,22 @@ static int tegra210_mvc_put_mute(struct snd_kcontrol *kcontrol,

...
>
> return 1;

It's a bit unrelated comment to this change, but it may be worth to verify all
kcontrol put callbacks in the tegra code. Ensure that value 1 is returned only
when something was really changed in hardware.

The tegra210_i2s_put_control() has opposite problem for example - returns
always 0 which means that the change notifications are not send to subscribed
applications.

Jaroslav

--
Jaroslav Kysela <perex@perex.cz>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.

\
 
 \ /
  Last update: 2021-10-25 14:58    [W:0.146 / U:0.528 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site