lkml.org 
[lkml]   [2021]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] tracing: Fix missing trace_boot_init_histograms kstrdup NULL checks
On Fri, 15 Oct 2021 15:55:50 -0400
Mathieu Desnoyers <mathieu.desnoyers@efficios.com> wrote:

> trace_boot_init_histograms misses NULL pointer checks for kstrdup
> failure.
>
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
> Cc: Steven Rostedt <rostedt@goodmis.org>

Masami,

Can you ack this?

-- Steve

> ---
> kernel/trace/trace_boot.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/kernel/trace/trace_boot.c b/kernel/trace/trace_boot.c
> index 8d252f63cd78..0580287d7a0d 100644
> --- a/kernel/trace/trace_boot.c
> +++ b/kernel/trace/trace_boot.c
> @@ -430,6 +430,8 @@ trace_boot_init_histograms(struct trace_event_file *file,
> /* All digit started node should be instances. */
> if (trace_boot_compose_hist_cmd(node, buf, size) == 0) {
> tmp = kstrdup(buf, GFP_KERNEL);
> + if (!tmp)
> + return;
> if (trigger_process_regex(file, buf) < 0)
> pr_err("Failed to apply hist trigger: %s\n", tmp);
> kfree(tmp);
> @@ -439,6 +441,8 @@ trace_boot_init_histograms(struct trace_event_file *file,
> if (xbc_node_find_subkey(hnode, "keys")) {
> if (trace_boot_compose_hist_cmd(hnode, buf, size) == 0) {
> tmp = kstrdup(buf, GFP_KERNEL);
> + if (!tmp)
> + return;
> if (trigger_process_regex(file, buf) < 0)
> pr_err("Failed to apply hist trigger: %s\n", tmp);
> kfree(tmp);

\
 
 \ /
  Last update: 2021-10-26 05:11    [W:0.057 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site