lkml.org 
[lkml]   [2021]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: linux-next: Tree for Oct 25 (drivers/platform/x86/amd-pmc.c)
From
Hi,

On 10/25/21 22:50, Randy Dunlap wrote:
> On 10/25/21 2:49 AM, Stephen Rothwell wrote:
>> Hi all,
>>
>> There seems to be something amiss with cnosole output in today's release
>> (at least on my ppc qemu boot tests).
>>
>> Changes since 20211022:
>>
>
> on x86_64:
>
> ../drivers/platform/x86/amd-pmc.c: In function ‘amd_pmc_verify_czn_rtc’:
> ../drivers/platform/x86/amd-pmc.c:428:30: error: ‘CONFIG_RTC_SYSTOHC_DEVICE’ undeclared (first use in this function); did you mean ‘CONFIG_RTC_HCTOSYS_DEVICE’?
>   rtc_device = rtc_class_open(CONFIG_RTC_SYSTOHC_DEVICE);
>                               ^~~~~~~~~~~~~~~~~~~~~~~~~
>                               CONFIG_RTC_HCTOSYS_DEVICE

Hmm, yes using either CONFIG setting is a problem since it is not always
defined. Both simply default to "rtc0" though and this is also which
standard distro configs use.

Mario, can we just replace CONFIG_RTC_SYSTOHC_DEVICE with "rtc0"
here to fix this ?

Regards,

Hans

\
 
 \ /
  Last update: 2021-10-25 23:29    [W:0.152 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site