lkml.org 
[lkml]   [2021]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 11/50] iio: adc128s052: Fix the error handling path of adc128_probe()
    Date
    From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

    commit bbcf40816b547b3c37af49168950491d20d81ce1 upstream.

    A successful 'regulator_enable()' call should be balanced by a
    corresponding 'regulator_disable()' call in the error handling path of the
    probe, as already done in the remove function.

    Update the error handling path accordingly.

    Fixes: 913b86468674 ("iio: adc: Add TI ADC128S052")
    Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
    Reviewed-by: Alexandru Ardelean <ardeleanalex@gmail.com>
    Link: https://lore.kernel.org/r/85189f1cfcf6f5f7b42d8730966f2a074b07b5f5.1629542160.git.christophe.jaillet@wanadoo.fr
    Cc: <Stable@vger.kernel.org>
    Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/iio/adc/ti-adc128s052.c | 6 ++++++
    1 file changed, 6 insertions(+)

    --- a/drivers/iio/adc/ti-adc128s052.c
    +++ b/drivers/iio/adc/ti-adc128s052.c
    @@ -169,7 +169,13 @@ static int adc128_probe(struct spi_devic
    mutex_init(&adc->lock);

    ret = iio_device_register(indio_dev);
    + if (ret)
    + goto err_disable_regulator;

    + return 0;
    +
    +err_disable_regulator:
    + regulator_disable(adc->reg);
    return ret;
    }


    \
     
     \ /
      Last update: 2021-10-25 21:40    [W:4.223 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site