Messages in this thread | | | Date | Mon, 25 Oct 2021 08:57:27 +0200 | From | Greg KH <> | Subject | Re: [PATCH] staging: r8188eu: avoid use of goto statement |
| |
On Mon, Oct 25, 2021 at 10:28:54AM +0530, Saurav Girepunje wrote: > Remove the goto statement from _rtw_init_cmd_priv(). In this function > goto statement can be replace by return statement. By replacing the > goto statement with return statement local variable "res" is also > not required.As on goto label exit, function only return it is not
You need a ' ' after the '.' here please.
> performing any cleanup.Avoiding goto will simplify the function.
Same here.
> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com> > --- > drivers/staging/r8188eu/core/rtw_cmd.c | 16 +++++----------- > 1 file changed, 5 insertions(+), 11 deletions(-) > > diff --git a/drivers/staging/r8188eu/core/rtw_cmd.c b/drivers/staging/r8188eu/core/rtw_cmd.c > index e17332677daa..22046bd5cf82 100644 > --- a/drivers/staging/r8188eu/core/rtw_cmd.c > +++ b/drivers/staging/r8188eu/core/rtw_cmd.c > @@ -19,7 +19,6 @@ No irqsave is necessary. > > static int _rtw_init_cmd_priv(struct cmd_priv *pcmdpriv) > { > - int res = _SUCCESS; >
Please also remove the extra blank line.
thanks,
greg k-h
| |