Messages in this thread | | | Date | Mon, 25 Oct 2021 12:12:20 +0530 | From | Vinod Koul <> | Subject | Re: [PATCH] dmaengine: milbeaut-hdmac: Prefer kcalloc over open coded arithmetic |
| |
On 04-09-21, 16:58, Len Baker wrote: > As noted in the "Deprecated Interfaces, Language Features, Attributes, > and Conventions" documentation [1], size calculations (especially > multiplication) should not be performed in memory allocator (or similar) > function arguments due to the risk of them overflowing. This could lead > to values wrapping around and a smaller allocation being made than the > caller was expecting. Using those allocations could lead to linear > overflows of heap memory and other misbehaviors. > > So, use the purpose specific kcalloc() function instead of the argument > size * count in the kzalloc() function.
Applied, thanks
-- ~Vinod
| |