lkml.org 
[lkml]   [2021]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] staging: r8188eu: Remove four unused semaphores
Date
On Sunday, October 24, 2021 2:30:11 PM CEST Greg Kroah-Hartman wrote:
> On Fri, Oct 22, 2021 at 01:39:36PM +0200, Fabio M. De Francesco wrote:
> > Remove four initialized but unused semaphores.
> >
> > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
>
> What semaphores were removed? Please be specific.
>
> And can this be broken up into "one removal per patch?"
>
> thanks,
>
> greg k-h
>
Hi Greg,

With all due respect (I mean it), I must say that I'm not going to split this
trivial work into four patches of two lines each.

I understand that here you have the last word. After all, yours the tree,
yours the rules.

However, I'm used to do only what I can understand. After noticing that you
can take in one shot the removal of 7000 unnecessary lines (e.g., please see
commit 7bdedfef085b), I really cannot understand why you cannot take also the
removal of four initialised but unused variables in one only go.

I'm really sorry but, if you cannot reconsider your decision, please drop
this patch. I'm pretty sure that someone else is willing to do what you
required, but not me.

Best regards,

Fabio


\
 
 \ /
  Last update: 2021-10-24 18:28    [W:2.227 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site