lkml.org 
[lkml]   [2021]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 2/6] input: ti_am335x_tsc: fix STEPCONFIG setup for Z2
    Date
    The Z2 step configuration doesn't erase the SEL_INP_SWC_3_0 bit-field
    before setting the ADC channel. This way its value could be corrupted by
    the ADC channel selected for the Z1 coordinate.

    Fixes: 8c896308fea ("input: ti_am335x_adc: use only FIFO0 and clean up a little")
    Signed-off-by: Dario Binacchi <dariobin@libero.it>
    ---

    drivers/input/touchscreen/ti_am335x_tsc.c | 5 ++++-
    1 file changed, 4 insertions(+), 1 deletion(-)

    diff --git a/drivers/input/touchscreen/ti_am335x_tsc.c b/drivers/input/touchscreen/ti_am335x_tsc.c
    index fd3ffdd23470..cfc943423241 100644
    --- a/drivers/input/touchscreen/ti_am335x_tsc.c
    +++ b/drivers/input/touchscreen/ti_am335x_tsc.c
    @@ -196,7 +196,10 @@ static void titsc_step_config(struct titsc *ts_dev)
    STEPCONFIG_OPENDLY);

    end_step++;
    - config |= STEPCONFIG_INP(ts_dev->inp_yn);
    + config = STEPCONFIG_MODE_HWSYNC |
    + STEPCONFIG_AVG_16 | ts_dev->bit_yp |
    + ts_dev->bit_xn | STEPCONFIG_INM_ADCREFM |
    + STEPCONFIG_INP(ts_dev->inp_yn);
    titsc_writel(ts_dev, REG_STEPCONFIG(end_step), config);
    titsc_writel(ts_dev, REG_STEPDELAY(end_step),
    STEPCONFIG_OPENDLY);
    --
    2.17.1
    \
     
     \ /
      Last update: 2021-10-24 17:09    [W:2.665 / U:0.172 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site