Messages in this thread | | | Subject | Re: [PATCH] irqchip: fix compile-testing without CONFIG_OF | From | Florian Fainelli <> | Date | Fri, 22 Oct 2021 12:12:46 -0700 |
| |
On 10/22/21 8:49 AM, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > Drivers using the new IRQCHIP_PLATFORM_DRIVER_BEGIN helper > fail to link when compile-testing without CONFIG_OF, > as that means CONFIG_IRQCHIP is disabled as well: > > ld.lld: error: undefined symbol: platform_irqchip_probe >>>> referenced by irq-meson-gpio.c >>>> irqchip/irq-meson-gpio.o:(meson_gpio_intc_driver) in archive drivers/built-in.a >>>> referenced by irq-mchp-eic.c >>>> irqchip/irq-mchp-eic.o:(mchp_eic_driver) in archive drivers/built-in.a > > As the drivers are not actually used in this case, just > making the reference to this symbol conditional helps > avoid the link failure. > > Fixes: f8410e626569 ("irqchip: Add IRQCHIP_PLATFORM_DRIVER_BEGIN/END and IRQCHIP_MATCH helper macros") > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> -- Florian
| |