Messages in this thread | | | Date | Fri, 22 Oct 2021 09:13:22 -0700 | From | Kees Cook <> | Subject | Re: [PATCH 6/7] arch: __get_wchan() || ARCH_STACKWALK |
| |
On Fri, Oct 22, 2021 at 05:09:39PM +0200, Peter Zijlstra wrote: > Use ARCH_STACKWALK to implement a generic __get_wchan(). > > STACKTRACE should be possible, but the various implementations of > stack_trace_save_tsk() are not consistent enough for this to work. > ARCH_STACKWALK is a smaller set of architectures with a better defined > interface. > > Since get_wchan() pins the task in a blocked state, it is not > necessary to take a reference on the task stack, the task isn't going > anywhere. > > Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Nice, this looks good.
Reviewed-by: Kees Cook <keescook@chromium.org>
-- Kees Cook
| |