Messages in this thread | | | From | "Li,Rongqing" <> | Subject | 答复: [PATCH] rbtree: Remove unneeded check c ondition in rb find first | Date | Fri, 22 Oct 2021 04:19:22 +0000 |
| |
Ping
-Li
> On Thu, Sep 30, 2021 at 03:16:36PM +0800, Li RongQing wrote: > > the variable c is int type, so change the following condition > > > > if (c <= 0) { > > > > } > > else if (c > 0) { > > > > } > > as: > > if (c <= 0) { > > > > } > > else { > > > > } > > > > Spotted-by: Michel Lespinasse <<michel@lespinasse.org>> > > Signed-off-by: Li RongQing <lirongqing@baidu.com> > > --- > > include/linux/rbtree.h | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/include/linux/rbtree.h b/include/linux/rbtree.h index > > 235047d..d5ac8f7 100644 > > --- a/include/linux/rbtree.h > > +++ b/include/linux/rbtree.h > > @@ -294,7 +294,7 @@ static inline void rb_replace_node_cached(struct > rb_node *victim, > > if (!c) > > match = node; > > node = node->rb_left; > > - } else if (c > 0) { > > + } else { > > node = node->rb_right; > > } > > } > > Looks good to me, thanks for the fix. > > Reviewed-by: Michel Lespinasse <michel@lespinasse.org> > > -- > Michel "walken" Lespinasse
| |